Okay
  Public Ticket #916099
Image height in Carousel portfolio
Closed

Comments

  •  2
    TJbaar started the conversation

    Is there a way to dynamically adjust the maximum image height in the carousel type portfolio, so that it corresponds to a percentage of the viewport's height ? 

    Because as of now the max height option totally breaks the responsive properties of the page... When it is active, resizing becomes weird, and setting a max height in pixels instead of percents makes no sense anyway as there are so many different screen sizes out there.

    I've linked to a portfolio page on the site I'm currently setting up. You'll see that everything seems fine until you get to photo n°24 (the one in the attached screenshot) which unlike all the other photos was taken in portrait orientation and looks totally out of place without a dynamic height system.

    Thanks for your help !

    Keep up the great work, Kalium is very pleasant to use.

  • [deleted] replied

    Hi,

    You are right at this point, however if all images have the same width then there will be a huge gap between the images that are taller than average height of previous and next image.

    If you want to show all images in variable width I can do this and see if it properly works for you. For this I am going to need to login to your FTP and try it by adding custom code so I see how it works in real time.

    To include your credentials click Insert Credentials button in editor toolbar. (See how)

  •   TJbaar replied privately
  • [deleted] replied

    Hi,

    I've added a quickfix for you in this file: kalium/tpls/portfolio-single-3.php


    (view large version)

    And also one small change in javascript file joinable.min.js (located here) so now the maximum height in mobile is 350 pixels. Does this works for you?

    We are going to make improvements in our upcoming version of Kalium about this issue.

  •  2
    TJbaar replied

    Well, first of all thanks for your help !

    It does look much better when the viewport is wide on a desktop. However resizing doesn't seem as responsive as before (see how in the first screenshot most of the image is cropped and you can't see the copyright text because the window isn't large enough). And on phones it's fine in landscape mode but not in portrait (see second screenshot where most of the image is cropped).

    Also, I think you added a piece of code that makes the 24th photo show up right away and I couldn't find how to disable that.

    Do you have any other ideas for improvement ? 

    Otherwise I I'll do without the fix for now and won't post photos in portrait orientation. I could also use the lightbox which works great ! But the carousel seemed like a much more elegant way of showing information about projects as well as photos. The simpler the better.

  •  2
    TJbaar replied

    Can you please help me get rid of the code that goes directly to the 24th image ? Thank you !

  • [deleted] replied

    Hi TJbaar,

    I am sorry that I forgot the code that goes directly to the 24th image, I have set that because I was refreshing the page and each I had to manually go to 24th image which tooks me about a minute so thats why I have applied that code.

    Actually I don't have any other alternative this issue, but I need to re-code the entire carousel to make it working the way you want.

    Do you want to revert back the changes in code that I have made?

  •  2
    TJbaar replied

    Hi, yes, I would like the theme to be reverted to normal. For the time being I will just edit portrait images so they fit in a landscape rectangle, and hopefully in a future Kalium update you and your team will code an even better carousel. Thanks for looking into this issue.

  • [deleted] replied

    Hi,

    Yes of course, we are constantly working to make Kalium better and better, so even this issue will be fixed.

    Have a great day.

  •  2
    TJbaar replied

    Can you revert the changes you made ? Thank you.

  •  2
    TJbaar replied

    Never mind, I replaced the modified files by the standard ones. Everything is back to normal. Thanks.

  • [deleted] replied

    Hi TJbaar,

    I'm glad to hear that

    Will set this ticket as solved from here.