Okay
  Public Ticket #2385719
One page section scroll doesn't work right in 3.0
Closed

Comments

  •  15
    hahni started the conversation

    After upgrading to 3.0 the section scroll on my start page doesn't work - the scroll works but it scrolls only to the position "after the header / menu".

    The sections are full screen height sections and so the scroll should do the job from one section to the next "full screen" - after upgrading its always the position without the header / menu size.

    Please make a quick fix because we have set the page in "coming soon mode".

  •  15
    hahni replied

    I think it depends on the sticky header.

    if sticky header is switched off: the full height row is visible

    if sticky header is switched on: the full height row moved down under the header


    this worked perfect in the old version

  • [deleted] replied

    Hi hahni,

    I can see that Arlind gave you a fix https://laborator.ticksy.com/ticket/2385722, does this solves the problem please?

    Thanks!

  •  15
    hahni replied

    no it does not work for the scroll problem

  • [deleted] replied

    Hi hahni,

    Can you please a video of this problem so I can better understand what is happening so we can provide a fix for this if that is a bug?

    Also please send me your Wordpress credentials, because I need to login to your site so we can test this live as you do in the video.

    To include your credentials click Insert Credentials button in editor toolbar (see how)so your reply will be private.

    Thanks!

  • bunducafe replied

    Same here. 

    After update the Sticky header is broken and does not show the smaller logo. Additionally I get an error code in includes/classes/core/kalium-helpers.php on line 353

    If I switch the sticky header off also the error message disappears. 

  • [deleted] replied

    Hi hahni,

    I need to login to your site and investigate this issue so I can provide you the fix.

    As for @bunducafe question, can you please apply this fix:

    Download this file and replace it in this directory (of the theme): /includes/functions/

    This should remove the PHP error.

  •   hahni replied privately
  • [deleted] replied

    I understand the issue, so the point is that Kalium assumes that sticky menu most of the time has header background thats why it scrolls the content a bit further to avoid hiding it from the menu, consider this case:

    https://demo.kaliumtheme.com/wedding/

    So in your case, this code solves the issue:

    <script>
    jQuery( document ).ready( function( $ ) {
        Kalium.Hooks.addFilter( 'ScrollToElement.scrollTo.offset', function( offset ) {
            if ( Kalium.Header.Sticky ) {
                offset += Kalium.Header.Sticky.getStickyHeight();
            }
            return offset;
        } );
    } );
    </script>
    
    I have added in theme options and now it works just the way you desire.