Okay
  Public Ticket #1846342
Duplicated code
Closed

Comments

  •  2
    mervinv started the conversation

    I found a bug I think.


    code (html source) is showing 2x same information which is filled-in in the left/right top menu bar. 

    I will try to explain. 

    ___________________________________________________________________________

    When you go into the Theme options and you use the fields 'Left text on top menu bar' or  ''Right text on top menu bar', the code is duplicated when you take a look a the source (html). 


    Site: http://aurum.pa6.nl/

    Screenshot: UDFC2J.jpg

    In the html code I see 2 times: LEFT-TEXT-MENU-BAR

    and 2 times: RIGHT-TEXT-MENU-BAR


    (if you take a look at the html source, and do CTRL+F on the input field you will see)



    The first is comming from  <div class="top-menu top-menu--gray top-menu--columns-2">


    The second is comming from <div class="top-menu top-menu--light top-menu--columns-2">




    With some code (html/rich snippet data) is showing double in the code and that can give some errors in metrics and search results.


    I hope you can fix this issue. 



    Love the theme and I am customizing it to the max :)

    p.s. I am using 3.4.1 

  •  1,559
    Laborator replied

    Hi there,

    Just make sure you do not switch the tabs too fast as the fields can be duplicated, otherwise this is not a bug as fields will not show doubled, I just checked it in our demo sites.

    Best regards,
    Laborator Team


      Documentation         Join Kalium Users Group

  •  2
    mervinv replied

    Hi,

    Switching what tabs?

    I installed multiple test sites and they do all the same. Everywehere when I use these field, they show up twice in the code.


    I checked other people sites with the same theme, and they have the same problem.

    Examples: https://www.ravenfury.com/ - https://www.vytishop.com/ 

    What is the solution for this?

  •  1,559
    Laborator replied

    Hi again,

    Sorry I misunderstood you, I thought you were talking about the admin area. The reason why it is showing twice is because one is for the desktop version and the other for mobile menu, as you can see in the menu it has a different layout and it is not possible to place the same menu at the bottom of the mobile menu so we had to use it twice. 

    Best regards,
    Laborator Team


      Documentation         Join Kalium Users Group

  •  2
    mervinv replied

    Thank you for the answer. I 'think' i understand now.

    I thought that "top-menu--gray" and "top-menu--light" were standing for the colors because you can also select the colors 'gray' or 'light'  for the header bar, where the code appears.

  •  1,559
    Laborator replied

    No worries I will set this ticket as solved, have a great weekendsmile.png 

    Best regards,
    Laborator Team


      Documentation         Join Kalium Users Group