Okay
  Public Ticket #1014419
Search & sharing bugs and more
Closed

Comments

  •  2
    Solarside started the conversation

    Hello,

    I hope 2017 starts well for everyone!

    First I want to say thank you for the Kalium 2.0, all works and looks fine for me in general!

    I found a few not critical bugs and want to ask for the fix advises or help.
    Please see the list below:


    1. Search field in the header menu: when you paste something "Search on site" title inside the filed doesn't disappear (see attachment). Everything is ok when you start to type...

    2. Google shows header menu titles on search results (see attachment), but not the site's title and short description. Can't find SEO settings on theme options menu (this is essential I think), so please help or advise how to fix.

    3. Facebook and VK sharing includes short codes in the post and it doesn't look cool and has to be fixed (see attachment).

    4. 'BE THE FIRST TO REVIEW' on the product review section is not shown on site's language... I have checked Woo localization and this line has correct translation. 


    5. Site visitors complain that site's player is not obvious, could you kindly provide me with the custom CSS for the darker background of the player? Would love to see player adjustments in the theme options with the future theme updates.

    6. I can't remove tool-bar on the top for the customers: I disabled this option for all customers via the 'user settings' but it is still shown... 

    Thank you in advance for your assistance!

  • [deleted] replied

    Hi Solarside,

    Thanks for your wishes, we wish you a great 2017 too

    1— Hmm sorry but i can't replicate this problem that you are having, this is how the search works for us: http://drops.laborator.co/vJcv

    I tested this on Firefox and Safari too and it is working as it should.

    2— Yes you are right at this point. We will add meta description for the theme as built in option in the upcoming update. If you want to improve your overall site SEO then we would suggest you to use Yoast SEO and it will handle all these aspects.


    3— Can you replace one file, it should fix this issue:

    Download this file and replace it in this directory (of the theme): /inc


    4— Download this file and replace it in this directory (of the theme): /woocommerce

    It should fix this issue.


    5— I think that you are talking for the player that you have added on your single item page, if yes, please add the code below to Custom CSS

    .video-js.vjs-default-skin .vjs-poster {
        background-color: #6b6969 !important;
    }

    6— Visitors doesn't see your Wordpress toolbar when they visit your site as you can see on this video when I open your website on a new incognito window http://drops.laborator.co/GR50

  •  2
    Solarside replied

    Hi Arlind,

    Many thanks for coming back to me on this.

    Please find my comments below:

    1. Re search: as I mentioned, all works fine when you start to type in search field, but if you paste the text - it mess up, please check the video https://dl.dropboxusercontent.com/u/1828680/search.mov

    6. Re toolbar - I was talking about registered customers, not visitors. When customer is logged in - it pop up, please see the video https://dl.dropboxusercontent.com/u/1828680/toolbar.mov

    All other points are solved from now!

    Thanks again for your help!

    Have a nice day, 
    Dima

  • [deleted] replied

    Hi Dima,

    1. You are correct, I have provided a fix for this and it will also contained in the next update:

    Download this file and replace it in this directory (of the theme): /assets/js

    If you don't see the change immediately, please hard-refresh your browser (CTRL/CMD+R) because it takes longer to load the changes, as they are saved in browser cache. Another option is to open new private/incognito window and try if it works.

    6. Can you please add the following code in functions.php (end of file):

    /**
    * Hide admin bar from certain user roles
    */
    function hide_admin_bar( $show ) {
    if ( current_user_can( 'customer' ) ) :
    return false;
    endif;
    return $show;
    }
    add_filter( 'show_admin_bar', 'hide_admin_bar' );

    This should hide the admin bar from customers as well.

    Have a great day 

  •  2
    Solarside replied

    Hi Arlind,

    Thank you for the update.

    Search issue is fixed, thanks.

    Regarding toolbar:

    I updated the functions.php with provided code and as a result toolbar is hided now for my admin account, but it is still visible for customers... Test customer account credentials attached, could you please check how it works your side?

    Cheers,

    Dima

    Site CredentialsWP
    WordPress Credentials
    Admin URL:http://store.mixedemotions.ru/my-account/
    Username:testcustomer
    Password:1Qwe$Asd
    {"wp":{"use":true,"adminUrl":"http://store.mixedemotions.ru/my-account/","username":"testcustomer","password":"1Qwe$Asd"},"ftp":{"use":false,"url":"","port":"","user":"","password":"","path":""}}

     

  • [deleted] replied

    Hi Dima,

    I have tried this on my shop:


    (view large version)

    It didn't showed the admin bar, it might be a plugin causing that to happen so you can test it.

  •  2
    Solarside replied

    Hi Arlind,

    I disabled all plugins which could possibly implement this issue and still no luck... 

    Did  you try on your shop with your admin account or with regular customer account? Because as I already mentioned after I added suggested code to functions.php it has disabled toolbar for my admin account but not for customers accounts... and this problem is really annoying me...

    I don't want to waste your and my time and If you insist that provided code is correct and this is not theme issue I will set up new clear wordpress shop with Kalium demo content and check how it goes. 

    Please confirm?

    Thanks,

    Dima


  • [deleted] replied

    Hi Solarside,

    It would help me more if you can provide FTP details here so I will debug the code and apply proper fix.

    To include your credentials click Insert Credentials button in editor toolbar. (See how)


  •   Solarside replied privately
  • [deleted] replied

    Hi Solarside,

    I have modified that function and it works now, so the admin bar is hidden with this code:

    /**
    * Hide admin bar from certain user roles
    */
    function hide_admin_bar_from_certain_users( $admin_bar ) {
    if ( current_user_can( 'customer' ) ) {
    return false;
    }
    return $admin_bar;
    }

    add_filter( 'show_admin_bar', 'hide_admin_bar_from_certain_users', 20000 );

    Please save it and you can apply it whenever you want.

  •  2
    Solarside replied

    H Arlind,

    Thank you, toolbar is now hided for customer accounts, but for some reasons it still implements my admin account  :( 


  • [deleted] replied

    Hi Solarside,

    Do you want to remove the sidebar for admin as well?

    Then delete the previous code and add this one:

    /**
     * Hide admin bar from certain user roles
     */
    function hide_admin_bar_from_certain_users( $admin_bar ) {
        return false;
    }
    add_filter( 'show_admin_bar', 'hide_admin_bar_from_certain_users', 20000 );
  •  2
    Solarside replied

    Hi Arlind, 

    I think something miss in translation, sorry, just to clarify: 

    I would like tool bar to be removed from customers only and I need tool bar to be available for my admin account.

    With the code you posted 1 day ago admin bar has been removed not only for customers, but for admins as well.

    Kind regards,

    Dmitry

  • [deleted] replied

    Hi Dmitry,

    Sorry for the misunderstanding, I just thought when you wrote:

    Thank you, toolbar is now hided for customer accounts, but for some reasons it still implements my admin account

    So I thought you wanted to hide the toolbar from all every user. Can you please be very specific how do you want the admin bar to appear and I will give the adequate code for that.

  •  2
    Solarside replied

    Hi Arlind,

    I hope the week starts well for you.

    What I want is:

    1. Toolbar to be hided for customers

    2. Toolbar to be available for admin

    That's all :)


    Thank you,

    Dmitry

  • [deleted] replied

    Hi Dmitry,

    I have checked the code and I dont know where is the problem, I've logged in with Customer Account:

    http://drops.laborator.co/GJF2

    And with admin account the toolbar is shown:

    http://drops.laborator.co/Hn2l

    So this is what you asked and it is working?!

  •  2
    Solarside replied

    Hi Arlind,
    I've tried to login with your account and it's working as it should, so problem is with my admin account.

    Don't know why it happens, I will try to create a new admin account and hope it will help...

    I have just one last question: do I need to replace the files you provided earlier each time I update the theme?

    Thank you very much for your help and time, I appreciate a lot.

    Kind regards,

    Dima

  • [deleted] replied

    Hi Dmitry,

    Well, it should work now for you.

    Actually the code that I have you:

    /**
    * Hide admin bar from certain user roles
    */
    function hide_admin_bar_from_certain_users( $admin_bar ) {
    if ( current_user_can( 'customer' ) ) {
    return false;
    }
    return $admin_bar;
    }

    add_filter( 'show_admin_bar', 'hide_admin_bar_from_certain_users', 20000 );

    Will be replaced when new update is applied, you can activate child theme if you want not to loose custom code you add to the theme.